api: Allow *.amazonaws.com but not s3 endpoints#729
Merged
Conversation
New() was rejecting enpoints with this address format: *.amazonaws.com, however, it should only reject *.s3.amazonaws.com. With this PR, addresses such as foo.us-east-1.elb.amazonaws.com will be accepted.
Member
Author
|
I didn't see the test error here. Now it is fixed. Can you review @harshavardhana and @balamurugana ? |
harshavardhana
approved these changes
Jun 29, 2017
harshavardhana
requested changes
Jun 30, 2017
| return ErrInvalidArgument("Endpoint url cannot have fully qualified paths.") | ||
| } | ||
| if strings.Contains(endpointURL.Host, ".amazonaws.com") { | ||
| if strings.Contains(endpointURL.Host, ".s3.amazonaws.com") { |
Member
There was a problem hiding this comment.
how does this work for s3.amazonaws.com ?
deekoder
requested review from
balamurugana and
donatello
and removed request for
balamurugana and
donatello
harshavardhana
approved these changes
Jun 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New() was rejecting endpoints with this address format: *.amazonaws.com,
however, it should only reject *.s3.amazonaws.com. With this PR,
addresses such as foo.us-east-1.elb.amazonaws.com will be accepted.
Fixes minio/mc#2198