fix: Extract region from s3-<region>.amazonaws.com#787
Merged
Conversation
This PR fixes a behavior problem on our end when URLs like s3-<region> are allowed we should use the region name automatically otherwise calls like GetBucketLocation() would fail by defaulting to `us-east-1`. Fixes minio#785
harshavardhana
force-pushed
the
fix-region
branch
from
23bd48c to
58844f2
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a behavior problem on our end when URLs
like
s3-<region>are allowed we should use the regionname automatically otherwise calls like GetBucketLocation()
would fail by defaulting to
us-east-1.Fixes #785