Fix preSign signature calculation to honor resource lists.#827
Merged
Conversation
Currenlty we used to sign all the query parameters, this is not in accordance with AWS S3 spec. We should only canonicalize query params which are present in resouce list. Fixes minio#825
Member
Author
krisis
approved these changes
Sep 27, 2017
vadmeste
approved these changes
Sep 27, 2017
Member
vadmeste
left a comment
vadmeste
left a comment
There was a problem hiding this comment.
LGTM & tested with utf8 characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currenlty we used to sign all the query parameters, this
is not in accordance with AWS S3 spec. We should only
canonicalize query params which are present in resouce list.
Fixes #825