add support of x-amz-acl header for v2 acl (ceph server, aws s3 v2)#876
Merged
Conversation
harshavardhana
requested changes
Nov 16, 2017
| func isAmzHeader(headerKey string) bool { | ||
| key := strings.ToLower(headerKey) | ||
|
|
||
| if strings.HasPrefix(key, "x-amz-meta-") || key == "x-amz-acl" { |
Member
There was a problem hiding this comment.
this can be done in one line here
return strings.HasPrefix(key, "x-amz-meta-") || key == "x-amz-acl"
harshavardhana
approved these changes
Nov 17, 2017
poornas
approved these changes
Nov 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use CEPH server for store object. CEPH has old protocol (v2) and use special header for set ACl for object. Also AWS S3 v2 use this header
I added support of this header and add test for this method