Skip to content

Conversation

@trim21
Copy link
Contributor

@trim21 trim21 commented Jun 4, 2023

close #1166

This PR doesn't affect any other PR, can be merged separately.

Also no need to run e2e tests, it only change build script, make it rewrite import path in .d.ts files

@trim21
Copy link
Contributor Author

trim21 commented Jun 8, 2023

@prakashsvmx do you mind review this first?

@prakashsvmx prakashsvmx requested a review from kaankabalak June 8, 2023 15:47
@trim21
Copy link
Contributor Author

trim21 commented Jun 8, 2023

consider to create a release for this PR to fix #1163 and #1166

@prakashsvmx prakashsvmx merged commit a06a034 into minio:master Jun 9, 2023
@trim21 trim21 deleted the fix-build-cjs-ext branch June 9, 2023 15:49
@oktapodia
Copy link

@prakashsvmx Any possibility to release this anytime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TS2691 when compiling type reference from version 7.1.1

5 participants