Skip to content

refactor listBuckets #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prakashsvmx merged 8 commits into from
Jul 6, 2023
Merged

refactor listBuckets #1179

prakashsvmx merged 8 commits into from
Jul 6, 2023

Conversation

@prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Jun 28, 2023

refactor listBuckets to typescript

@prakashsvmx prakashsvmx self-assigned this Jun 28, 2023
@prakashsvmx prakashsvmx requested a review from kaankabalak June 28, 2023 13:24
trim21
trim21 reviewed Jun 28, 2023
View reviewed changes
trim21
trim21 reviewed Jul 3, 2023
View reviewed changes
trim21
trim21 reviewed Jul 3, 2023
View reviewed changes
trim21
trim21 reviewed Jul 3, 2023
View reviewed changes
@trim21
Copy link
Contributor

trim21 commented Jul 3, 2023

Import type from minio.d.ts will cause resolution problem in dist files

trim21
trim21 reviewed Jul 4, 2023
View reviewed changes
@prakashsvmx prakashsvmx requested a review from trim21 July 4, 2023 05:23
@trim21
Copy link
Contributor

trim21 commented Jul 4, 2023

lgtm

trim21
trim21 reviewed Jul 4, 2023
View reviewed changes
kaankabalak
kaankabalak approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx requested a review from trim21 July 6, 2023 03:51
trim21
trim21 reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@trim21 trim21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit 6cf40a7 into minio:master Jul 6, 2023
@VaniHaripriya VaniHaripriya mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaankabalak kaankabalak kaankabalak approved these changes

+1 more reviewer

@trim21 trim21 trim21 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@prakashsvmx prakashsvmx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prakashsvmx @trim21 @kaankabalak