Added missing properties for BucketItem union type #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
requested review from
balamurugana,
dvaldivia,
harshavardhana,
kaankabalak and
prakashsvmx
harshavardhana
approved these changes
Aug 30, 2023
kaankabalak
approved these changes
Aug 31, 2023
prakashsvmx
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
There are some missing properties in the BucketItem type Union, this PR adds them so TS can detect the correct elements returned by this type differentiating between prefix struct & name/etag struct.
How does it look
Before:
After: