refactor: makeBucket
#1222
Merged
refactor: makeBucket
#1222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| step('makeBucket(bucketName, region, cb)_region:eu-central-1_', (done) => | ||
| client.makeBucket(`${bucketName}.sec.period`, 'eu-central-1', done), | ||
| step('makeBucket(bucketName, region, cb)_region:eu-central-1_', () => | ||
| client.makeBucket(`${bucketName}.sec.period`, 'eu-central-1'), |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| isDifferentServerRegion = true | ||
| done() | ||
| } | ||
| clientUsEastRegion.makeBucket(`${bucketName}-region`, 'us-east-2', (err) => { |
Check failure
Code scanning / CodeQL
Hard-coded credentials
Contributor
Author
|
security warnings are false positive... |
Contributor
Author
|
resolve conflicts |
Contributor
Author
|
@prakashsvmx would you mind review this PR and approve ci? and looks like CodeQL workflow failed, do you have any idea how to fix this? |
Member
This is a false positive, I think I ignored it in the past, let me check again. |
Contributor
Author
prakashsvmx
approved these changes
Nov 13, 2023
Contributor
Author
kaankabalak
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.