fix: don't use DEFAULT_REGION for listBuckets method #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@prakashsvmx @kaankabalak Can we get this reviewed, please? |
kaankabalak
approved these changes
Dec 14, 2023
Member
|
i need to validate this with AWS. |
prakashsvmx
approved these changes
Jan 31, 2024
Contributor
Author
|
@prakashsvmx Have you validate this with AWS S3? |
prakashsvmx
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1148
Previously I remembered that I change this line of code to fix that issue. It turns out, I haven't.
Please try to test it with both S3 and MinIO backends.