Skip to content

Conversation

@aldy505
Copy link
Contributor

@aldy505 aldy505 commented Dec 10, 2023

  • Bump dependencies on CI to use latest versions
  • Remove Node 12 and Node 14 tests, as we don't support them anymore. They're not maintained versions either.

On the package.json file, it is defined that the minimum of Node.js version is 16. So it makes sense to drop version 12 and 14.

minio-js/package.json

Lines 75 to 77 in 51cf376

"engines": {
"node": "^16 || ^18 || >=20"
},

@trim21
Copy link
Contributor

trim21 commented Dec 12, 2023

should we also downgrade @types/node to v16?

@aldy505
Copy link
Contributor Author

aldy505 commented Dec 13, 2023

should we also downgrade @types/node to v16?

@trim21 No need, right? We're bundling everything with Babel anyway.

@trim21
Copy link
Contributor

trim21 commented Dec 13, 2023

should we also downgrade @types/node to v16?

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

@aldy505
Copy link
Contributor Author

aldy505 commented Dec 18, 2023

should we also downgrade @types/node to v16?

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

@trim21
Copy link
Contributor

trim21 commented Dec 18, 2023

should we also downgrade @types/node to v16?

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

yes, transpiling only

@aldy505
Copy link
Contributor Author

aldy505 commented Dec 19, 2023

should we also downgrade @types/node to v16?

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

yes, transpiling only

Ah that should be good enough.

Can I have this reviewed, please? @kaankabalak @prakashsvmx

@prakashsvmx
Copy link
Member

the CI still looks for tests on old version of node 12 on windows/ubuntu
Test on node 12.x and ubuntu-latest
Test on node 12.x and windows-latest

We will check this. @aldy505

@aldy505
Copy link
Contributor Author

aldy505 commented Feb 7, 2024

@prakashsvmx Hi, any updates?

@prakashsvmx
Copy link
Member

I think it requires some admin access at the org level , i will check further.

@harshavardhana harshavardhana merged commit 114ba7a into minio:master Apr 30, 2024
@trim21
Copy link
Contributor

trim21 commented Apr 30, 2024

@trim21
Copy link
Contributor

trim21 commented Apr 30, 2024

also

'@upleveled/remove-node-prefix', // lower version of node (<14) doesn't support require('node:fs')

@aldy505 aldy505 deleted the ci/bump-version branch May 1, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants