-
Notifications
You must be signed in to change notification settings - Fork 309
ci: bump dependencies; remove node 12 and node 14 #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
should we also downgrade |
@trim21 No need, right? We're bundling everything with Babel anyway. |
we didn't bundle anything |
I thought Babel was for transpiling to older Nodejs versions, no? |
yes, transpiling only |
Ah that should be good enough. Can I have this reviewed, please? @kaankabalak @prakashsvmx |
|
the CI still looks for tests on old version of node 12 on windows/ubuntu We will check this. @aldy505 |
|
@prakashsvmx Hi, any updates? |
|
I think it requires some admin access at the org level , i will check further. |
|
should also remove file https://github.com/minio/minio-js/blob/master/src/internal/async.ts .... |
|
also Line 22 in 114ba7a
|
On the
package.jsonfile, it is defined that the minimum of Node.js version is 16. So it makes sense to drop version 12 and 14.minio-js/package.json
Lines 75 to 77 in 51cf376