Skip to content

fix: uploadPart cannot upload stream and etag error #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshavardhana merged 2 commits into from
Oct 25, 2024
Merged

fix: uploadPart cannot upload stream and etag error #1334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ade4f6
fix: uploadPart cannot upload stream and etag error
Aug 14, 2024
709448a
Update src/internal/client.ts
harshavardhana Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions src/internal/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ import {
parseInitiateMultipart,
parseObjectLegalHoldConfig,
parseSelectObjectContentResponse,
uploadPartParser,
} from './xml-parser.ts'

const xml = new xml2js.Builder({ renderOpts: { pretty: false }, headless: true })
Expand Down Expand Up @@ -2641,25 +2640,24 @@ export class TypedClient {
return await this.copyObjectV2(source, dest)
}

async uploadPart(partConfig: {
bucketName: string
objectName: string
uploadID: string
partNumber: number
headers: RequestHeaders
}) {
async uploadPart(
partConfig: {
bucketName: string
objectName: string
uploadID: string
partNumber: number
headers: RequestHeaders
},
payload?: Binary,
) {
const { bucketName, objectName, uploadID, partNumber, headers } = partConfig

const method = 'PUT'
const query = `uploadId=${uploadID}&partNumber=${partNumber}`
const requestOptions = { method, bucketName, objectName: objectName, query, headers }

const res = await this.makeRequestAsync(requestOptions)
const body = await readAsString(res)
const partRes = uploadPartParser(body)

const res = await this.makeRequestAsync(requestOptions, payload)
return {
etag: sanitizeETag(partRes.ETag),
etag: sanitizeETag(res.headers.etag),
key: objectName,
part: partNumber,
}
Expand Down