Skip to content

force xml parser to treat bucket name as string in listBuckets API #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prakashsvmx merged 1 commit into from
Sep 4, 2024
Merged

force xml parser to treat bucket name as string in listBuckets API #1343

prakashsvmx merged 1 commit into from
Sep 4, 2024

Conversation

@prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Sep 3, 2024 •
edited
Loading

fixes #1340

Sample results.

 [
  { name: '0000test-bucket', creationDate: 2024-09-03T09:29:38.112Z },
  {
    name: '01110000111100001111000011110000',
    creationDate: 2024-09-03T08:39:04.766Z
  },
  { name: '01test-bucket', creationDate: 2024-09-03T09:29:33.168Z },
  { name: '0test-bucket', creationDate: 2024-09-03T09:29:29.961Z },
  { name: '90test-bucket', creationDate: 2024-09-03T09:29:43.040Z },
  { name: 'test-bucket', creationDate: 2024-09-03T07:11:19.678Z }
]

@prakashsvmx prakashsvmx self-assigned this Sep 3, 2024
@prakashsvmx prakashsvmx mentioned this pull request Sep 3, 2024
Closed
bayasdev
bayasdev approved these changes Sep 3, 2024
View reviewed changes
Copy link

@bayasdev bayasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prakashsvmx prakashsvmx merged commit 147072e into minio:master Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaankabalak kaankabalak kaankabalak approved these changes

+1 more reviewer

@bayasdev bayasdev bayasdev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@prakashsvmx prakashsvmx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

listBuckets return name as number not string

3 participants

@prakashsvmx @kaankabalak @bayasdev