Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from Fedimint v0.8.0 to v0.9.0. The migration includes dependency updates, new required crypto provider initialization, and enhanced gateway selection with automatic fallback support.
Key changes:
- Updated all Fedimint dependencies from v0.8.0 to v0.9.0
- Added crypto provider initialization required for v0.9.0 TLS operations
- Made
gateway_idoptional in invoice and payment requests with automatic gateway selection fallback
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/core/mod.rs | Made gateway_id optional in request structs and implemented automatic gateway selection logic with fallback |
| src/bin/main.rs | Added required crypto provider initialization call for v0.9.0 |
| scripts/mprocs-nix-gateway.sh | Removed obsolete script file |
| flake.nix | Updated dependencies: Fedimint to v0.9.0, nixpkgs to unstable, flakebox to specific commit, Rust channel to "latest" |
| flake.lock | Lock file updates for dependency changes |
| V0.9.0_MIGRATION_PLAN.md | Added comprehensive migration plan documentation |
| Cargo.toml | Updated all Fedimint dependency versions from 0.8.0 to 0.9.0 |
| Cargo.lock | Lock file updates for Cargo dependency changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| pub description: String, | ||
| pub expiry_time: Option<u64>, | ||
| pub gateway_id: PublicKey, | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] |
There was a problem hiding this comment.
The skip_serializing_if attribute is used here but the struct has #[derive(Debug, Deserialize)] without Serialize. Since this struct is only used for deserialization (incoming requests), skip_serializing_if has no effect and should be removed.
| #[serde(default, skip_serializing_if = "Option::is_none")] | |
| #[serde(default)] |
| pub amount_msat: Option<Amount>, | ||
| pub lnurl_comment: Option<String>, | ||
| pub gateway_id: PublicKey, | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] |
There was a problem hiding this comment.
The skip_serializing_if attribute is used here but the struct has #[derive(Debug, Deserialize)] without Serialize. Since this struct is only used for deserialization (incoming requests), skip_serializing_if has no effect and should be removed.
1 participant
tracks #13