Skip to content

Swap out the handrolled Mempool mock for a mockall implementation #957

Closed
@alfiedotwtf

Description

@alfiedotwtf

If I remember correctly, the reason I created the hand-rolled Mempool mock was because there were circular dependancies within blockprod pulling in chainstate and mempool. which was one of the reasons why the mocks were moved to /mocks/. However after @ImplOfAnImpl's discussion on Atomics, it made me have another look at the Mempool mock given that there are a lot of Atomics in there.

I have a local change which implements the Mempool mock using mockall, which seems to now work within blockprod. I'm creating the issue as a reminder to update blockprod tests with the mockall Mempool implementation.

Metadata

Metadata

Assignees

Labels

mempoolMempool-related issuestestingTests & testing infrastructure

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions