Skip to content

Fix p2p test timeout on coverage #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix p2p test timeout on coverage #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ffa988
Decrease number of blocks in p2p test
azarovh Oct 8, 2023
ece3cdc
Increase LONG_TIMEOUT instead
azarovh Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion p2p/p2p-test-utils/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ impl P2pBasicTestTimeGetter {
}

/// A timeout for blocking calls.
pub const LONG_TIMEOUT: Duration = Duration::from_secs(60);
pub const LONG_TIMEOUT: Duration = Duration::from_secs(120);
/// A short timeout for events that shouldn't occur.
pub const SHORT_TIMEOUT: Duration = Duration::from_millis(500);

Expand Down
2 changes: 1 addition & 1 deletion p2p/src/sync/tests/network_sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ async fn basic(#[case] seed: Seed) {
#[trace]
#[case(Seed::from_entropy())]
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn initial_download_unexpected_disconnect(#[case] seed: Seed) {
async fn no_unexpected_disconnects_in_ibd(#[case] seed: Seed) {
for_each_protocol_version(|protocol_version| async move {
let mut rng = test_utils::random::make_seedable_rng(seed);
let chain_config = Arc::new(common::chain::config::create_unit_test_config());
Expand Down