Skip to content

Isolate database expensive reads in its own module and isolate its use lines to avoid unused warnings #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TheQuantumPhysicist merged 2 commits into from
Oct 23, 2023
Merged

Isolate database expensive reads in its own module and isolate its use lines to avoid unused warnings #1290

TheQuantumPhysicist merged 2 commits into from
Oct 23, 2023

Conversation

@TheQuantumPhysicist
Copy link
Contributor

@TheQuantumPhysicist TheQuantumPhysicist commented Oct 23, 2023 •
edited
Loading

The warning would happen when running something that doesn't involve tests, such as cargo run --bin node-daemon.

@TheQuantumPhysicist TheQuantumPhysicist merged commit 7e3a907 into master Oct 23, 2023
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/expensive_reads_module branch October 23, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@muursh muursh Awaiting requested review from muursh

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@iljakuklic iljakuklic Awaiting requested review from iljakuklic

@azarovh azarovh Awaiting requested review from azarovh

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TheQuantumPhysicist