Tweaks for the PR to r-lib/styler#463 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@lorenzwalthert, Thanks for the review, I am fine with your proposed simplifications.
See below for two more specific comments.
lorenzwalthert
force-pushed
the
addin-select-style
branch
from
320ca36 to
418dea5
Compare
lorenzwalthert
force-pushed
the
addin-select-style
branch
from
418dea5 to
d2a87ef
Compare
Co-Authored-By: lorenzwalthert <[email protected]>
Co-Authored-By: lorenzwalthert <[email protected]>
|
@riccardoporreca thanks for your second review pass, I was not really careful with these suggestions 😞 |
|
@lorenzwalthert, no worries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reviewed your r-lib/styler#463 and figured I'd need to test things myself so I ended up changing the code quite a bit myself and found it would be easier to propose this change to your repo, so once this is merged, we can merge r-lib/styler#463. If you agree. I started with the following observation: The regex match for package namespace and namespace object (i.e.
match_fun()) can be replaced witheval(parse(...))statement while retaining the property of matching bothpkg::funandfunnotation. Then, I removed the Addins setters and getters because they are both oneliners and wrapping them inside another function call adds more cognitive overhead (for me at least) than it hides abstraction. Finally, I added some documentation and removed the package styler Addin. Sorry I did not commit the latter separately but it's convoluted in 3d57c3e, so you may want manually add this to your fork in case you want to keep it. What do you think?