Skip to content

Compress data #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EtienneLem merged 2 commits into from
Sep 13, 2017
Merged

Compress data #111

EtienneLem merged 2 commits into from
Sep 13, 2017

Conversation

@ai
Copy link

@ai ai commented Sep 11, 2017

@EtienneLem More than 10% compression!

  1. Data was moved from data/index.js to data/data.js.
  2. Many fields were removed from data/data.js.
  3. Uncompress code was added to data/index.js to add all fields removed in step 2.

As result API is the same (require('emoji-mart/data') return the same object), but size is smaller!

@EtienneLem EtienneLem merged commit 9bf9eb6 into missive:master Sep 13, 2017
@EtienneLem
Copy link
Member

EtienneLem commented Sep 13, 2017

Impressive! Well done 🤘

@ai ai mentioned this pull request Nov 28, 2017
Closed
This was referenced May 23, 2018
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Open
@atielking atielking mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ai @EtienneLem