-
Notifications
You must be signed in to change notification settings - Fork 2
chore(deps): update dependency hypothesis to v6 #3512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a3ed958
to
79a9343
Compare
79a9343
to
975efe2
Compare
d1109b0
to
23449e5
Compare
23449e5
to
c9b1183
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
In this upgrade, the tests began failing in CI with the error:
The main problem here seems to be the name collision between Django's TestCase.settings method and Hypothesis settings object. Our test class inherits from both Django's run_state_machine_as_test(cls, settings=self.settings)
This was previously being ignored but arises now probably because hypothesis 6.116.0+ introduced stricter CI type checking. Also note the error doesn't arise when the tests are run locally. To fix this, I changed the inheritance order so Python finds Hypothesis's settings first instead of Django's. This fixed the type mismatch. From what I understand, now that the settings collision is resolved, Hypothesis can actually run the state machine test properly. But it discovered a problem with our test design, throwing
Some of our test flows are "dead ends" - they start a user journey but don't lead anywhere. Specifically, when a user tries to login with an email that doesn't exist |
After fixing the Hypothesis settings collision, I've been addressing individual dead-end rules one by one (login_email_not_exists, login_password_exports_temporary_error, login_password_valid, now login_password_user_inactive), but each fix just reveals another rule with the same pattern - they consume bundles but don't produce any, causing TLDR: The fundamental issue is our bundle/flow design doesn't align with the natural terminal nature of authentication flows. |
This PR contains the following updates:
4.24.6
->6.133.2
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.