Renaming LogCallback to avoid name conflicts#142
Open
jeongseok-meta wants to merge 1 commit intomitsuba-renderer:masterfrom
Open
Renaming LogCallback to avoid name conflicts#142jeongseok-meta wants to merge 1 commit intomitsuba-renderer:masterfrom
LogCallback to avoid name conflicts#142jeongseok-meta wants to merge 1 commit intomitsuba-renderer:masterfrom
Conversation
jeongseok-meta
force-pushed
the
name_confict
branch
from
e9bebce to
aa99100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LogCallbackis a relatively common name that may cause naming conflicts with other libraries when defined in the global scope. To avoid this issue, please consider prefixing it with a unique identifier, such asJit, to create a more distinctive name likeJitLogCallback. Thanks!