Fix android 32-bit build errors#143
Open
jeongseok-meta wants to merge 1 commit intomitsuba-renderer:masterfrom
Open
Fix android 32-bit build errors#143jeongseok-meta wants to merge 1 commit intomitsuba-renderer:masterfrom
jeongseok-meta wants to merge 1 commit intomitsuba-renderer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that building for Android 32-bit was failing due to the use of
__arch64__for checking ARM platforms, which is only defined for 64-bit Android architectures. To fix this, I've updated the code to also check for__arm__, ensuring that our project can correctly identify and build for both 32-bit and 64-bit ARM-based Android platforms.Related PR: mitsuba-renderer/drjit#389