Codespell fixes #10947

Holzhaus · 2022-10-07T22:28:18Z

Attempt to solve #10946 by getting rid of the custom codespell wrapper, which not only makes pre-commit hard to use on windows, it's also broken (pre-commit run codespell --all-files does not work). Pre-commit failues are expected and should be ignored, because this touches a lot of files.

@JoergAtGithub please check if pre-commit run codespell --all-files works when you have this branch checked out.

JoergAtGithub · 2022-10-08T09:35:29Z

Now the execution of codespell starts, but it seems codespell itself crashes:

PS C:\Users\Joerg.WORLDWARTWEB\source\repos\JoergAtGithub\mixxx> pre-commit run codespell --all-files
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-eslint.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-eslint:[email protected].
[INFO] Initializing environment for local.
[INFO] Initializing environment for https://github.com/psf/black.
[INFO] Initializing environment for https://gitlab.com/pycqa/flake8.
[INFO] Initializing environment for https://github.com/shellcheck-py/shellcheck-py.
[INFO] Initializing environment for https://github.com/DavidAnson/markdownlint-cli2.
[INFO] Initializing environment for https://github.com/sirosen/check-jsonschema.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-prettier:[email protected].
[INFO] Initializing environment for local:tinycss==0.4.
[INFO] Initializing environment for local:Markdown==3.3.4,beautifulsoup4==4.9.3,lxml==4.6.3.
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
codespell................................................................Failed
- hook id: codespell
- exit code: 1

Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>
Traceback (most recent call last):
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\Scripts\codespell.EXE\__main__.py", line 7, in <module>
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 748, in _script_main
    return main(*sys.argv[1:])
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 862, in main
    build_exclude_hashes(options.exclude_file, exclude_lines)
  File "C:\Users\Joerg.WORLDWARTWEB\.cache\pre-commit\reporvepfeq7\py_env-python3\lib\site-packages\codespell_lib\_codespell.py", line 444, in build_exclude_hashes
    for line in f:
  File "C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python39_64\lib\encodings\cp1252.py", line 23, in decode
    return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 2244: character maps to <undefined>

Holzhaus · 2022-10-08T18:30:32Z

Now that really is an upstream issue. We can update the codespell hook in .pre-commit-config.yaml to check if the issue is already fixed, but if not we should report it upstream at the codespell repo I guess.

JoergAtGithub · 2022-10-08T18:53:05Z

This was easy to fix: codespell-project/codespell#2520

Holzhaus · 2022-10-08T18:59:12Z

Ah, because Python's open uses the system encoding, and Windows localized in German uses cp1252 encoding by default?

JoergAtGithub · 2022-10-08T19:08:21Z

I guess this is the case. I copied this line from another function in this file. This line was the only open statement which didn't specify the encoding.

Regarding this PR, I confirm, that it fixes codespell execution under Windows!

JoergAtGithub · 2022-10-15T19:20:27Z

Codespell 2.2.2 is released, with my bugfix merged: https://github.com/codespell-project/codespell/releases/tag/v2.2.2

Holzhaus · 2022-10-15T20:02:16Z

Codespell 2.2.2 is released, with my bugfix merged: https://github.com/codespell-project/codespell/releases/tag/v2.2.2

#10970

Holzhaus · 2022-10-18T22:23:06Z

The pre-commit issue is expected because the spelling fixes touch a lot of files, including files that have formatting issues. Merge?

daschuer

Yes, Thank you.
There are some more findings. But that does not matter.

github-actions bot added build code quality controller mappings library skins ui labels Oct 7, 2022

Holzhaus removed controller mappings skins library ui build labels Oct 8, 2022

Holzhaus added 2 commits October 15, 2022 22:03

ci(pre-commit): Get rid of codespell wrapper script

83f4b62

chore(pre-commit): Add all codespell errors in the code base

3b1642e

Holzhaus force-pushed the codespell-fixes branch from 89d8611 to 3b1642e Compare October 15, 2022 20:04

github-actions bot added build controller mappings library skins ui labels Oct 15, 2022

daschuer approved these changes Oct 19, 2022

View reviewed changes

daschuer merged commit 1fe083b into mixxxdj:2.3 Oct 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Codespell fixes #10947

Codespell fixes #10947

Uh oh!

Holzhaus commented Oct 7, 2022

Uh oh!

JoergAtGithub commented Oct 8, 2022

Uh oh!

Holzhaus commented Oct 8, 2022

Uh oh!

JoergAtGithub commented Oct 8, 2022

Uh oh!

Holzhaus commented Oct 8, 2022 •

edited

Loading

Uh oh!

JoergAtGithub commented Oct 8, 2022

Uh oh!

JoergAtGithub commented Oct 15, 2022

Uh oh!

Holzhaus commented Oct 15, 2022

Uh oh!

Holzhaus commented Oct 18, 2022 •

edited

Loading

Uh oh!

daschuer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Codespell fixes #10947

Codespell fixes #10947

Uh oh!

Conversation

Holzhaus commented Oct 7, 2022

Uh oh!

JoergAtGithub commented Oct 8, 2022

Uh oh!

Holzhaus commented Oct 8, 2022

Uh oh!

JoergAtGithub commented Oct 8, 2022

Uh oh!

Holzhaus commented Oct 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoergAtGithub commented Oct 8, 2022

Uh oh!

JoergAtGithub commented Oct 15, 2022

Uh oh!

Holzhaus commented Oct 15, 2022

Uh oh!

Holzhaus commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daschuer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Holzhaus commented Oct 8, 2022 •

edited

Loading

Holzhaus commented Oct 18, 2022 •

edited

Loading