Skip to content

Remove processing of R2 reverse reads, check for fastq files, use Python 3.6, and badge fixes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

eburgoswisc
Copy link
Collaborator

  • Added a check for reversed reads. If present, the program will skip it. Helps with having a cleaner counts table.

  • Added a check for fastq and fastq.gz sequence files

  • Update badges in README.md

  • Refactored rules in Makefile

  • Fixed Travis CI yml. Need to stay with python 3.6.

…tq.gz files (#1)

* Added a check for reversed reads. If present, program will skip it. Helps with having a cleaner counts table.

* Added a check for fastq and fastq.gz sequence files

* NEED THIS TO TEST TRAVIS CI

* Forgot -s option to view stdout

* Getting tired...

* See if this works

* Lets keep going

* Lets keep going mjmlab#2

* Fixed Travis CI. Need to stay with python 3.6.

* Final fix
@eburgoswisc
Copy link
Collaborator Author

@mandel01 If everything looks good, feel free to squash and merge.

@eburgoswisc eburgoswisc removed the request for review from hburgosrobles January 7, 2021 16:22
@mandel01
Copy link
Contributor

mandel01 commented Jan 7, 2021

Looks great!

For the docs, maybe edit:

Directory of Illumina reads [-i] for analyzing. Can be either fastq or fastq.gz format

to read

Directory of Illumina reads [-i] for analyzing. Can be either fastq or fastq.gz format. If paired reads are provided, barseq only uses the forward reads.

@mandel01
Copy link
Contributor

mandel01 commented Jan 7, 2021

In test_main.py, do you need the pandas import?

- Can run `barseq` without providing barcode files
- Improved code functions
- Updated test functions
- Can now modify flanking seq and barcode length to search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants