Switch from ravel_multi_index to a faster vectorized alternative. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have tests, we can be slightly confident that this works.
|
ouch. tests are failing now! |
|
Still a decent speedup for > 1000 elements using code in #46
|
dcherian
added a commit
to dcherian/numpy-groupies
that referenced
this pull request
Apr 26, 2022
* master: Switch from ravel_multi_index to a faster vectorized alternative. (ml31415#51)
dcherian
added a commit
to dcherian/numpy-groupies
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have tests, we can be slightly confident that this works.