Skip to content

Conversation

@sahilavaran
Copy link
Contributor

No description provided.

@sahilavaran sahilavaran requested a review from a team as a code owner March 1, 2025 18:29
@github-actions
Copy link

github-actions bot commented Mar 1, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sahilavaran sahilavaran changed the title Updated test_mlc_access.py and added logging and pytest Updated test_mlc_access.py and added logging and assert statement Mar 6, 2025
@anandhu-eng
Copy link
Contributor

anandhu-eng commented Mar 7, 2025

Hi @sahilavaran , the error in this test case arose because it tried to access the logger.py file.

>>> import mlc
>>> mlc.logger
<module 'mlc.logger' from '/home/anandhu/testing/mlcflow/mlc/logger.py'>

I think we could provide an endpoint for the users(could be found in this PR) to get the MLC logger.

@sahilavaran
Copy link
Contributor Author

@anandhu-eng added as per your PR

@anandhu-eng anandhu-eng marked this pull request as draft April 1, 2025 14:14
@anandhu-eng
Copy link
Contributor

Hi @sahilavaran , Thanks for the PR. I have reverted the usage of logger from MLCFlow as it is not needed to be exposed. I have closed the PR that exposed the logger.

@anandhu-eng anandhu-eng marked this pull request as ready for review April 1, 2025 14:29
@arjunsuresh arjunsuresh merged commit 775a0a2 into mlcommons:dev Apr 1, 2025
37 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants