Updating link-section to use private sections#469
Merged
Conversation
mmastrac
added a commit
that referenced
this pull request
May 28, 2026
Implements a new umbrella macro `combine!` that handles string and ident concatenation for various things we need. Replaces the old macros with compat stubs for now - we'll be reworking things in the future. This is like a version of `concat!` and `stringify!` on steroids. It mostly performs string concatenation, but callers may embed `__FUNCTION__(...)` calls internally which are evaluated before being appending to the ident or string. Extracted from #469
mmastrac
force-pushed
the
link-section-names
branch
from
746a28e to
b9150d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For sections that don't use
unsafe, we'll generate a per-section unique hash based on the location of the section to ensure that multiple sections with the same base name don't collide.For sections that do use
unsafe, we will only use the hash if the name overflows the platform-specific length maximum.The crate now explictly disallows anything but
name =whenunsafeis used, andunsafeis now required if theproc_macrofeature is not enabled.scattered-collectgets updated for all the various changes.