Bar Icons don't look very well

[steelbrain]

Please look at the bottom of the screenshot, or zoom it maybe to see the pixelated icons of hexchat skype and chrome.

Update: The chrome icon for running apps is clearer than the chrome icon in the bookmarks area.

[kirvedx]

Judging from your screen shot you're using several extensions which modify the topbar -> this is causing likely all of your problems since:

1 - Some of those extensions take up indexes in the aggregate menu - thus creating conflict with MMOD-Panel items that should be in those respective index positions.

And that really sums it up. By default the settings icon shouldn't even be appearing (Huge Google Chrome Icon), and on a good install favorites do not show twice (other than applications which are known to have issues..which is chrome and eclipse at times - though atm chrome isn't producing that issue, just eclipse).

The pixelated icons are a bit confusing to me as well -> not sure why that is happening. Though it'll be hard to target the cause without you removing all the extensions (or temporarily disabling those) that are conflicting.

If you list me all the extensions you have installed which modify the topbar, I can attempt to see if there is a way to support them existing - and playing nicely - with MMOD-Panel.

[steelbrain]

I have these extensions installed and activated, the activated extensions are checked.

• AlternateTab
• Applications Menu
• Auto move windows
• Battery Percentage
• Clipboard Indicator
• Disconnect Wifi
• EasyScreenCast
• Grub Reboot
• Launch New Instance
• MmodPanel
• Media Player Indicator
• Native window placement
• Netspeed
• Patterend Wallpapers
• Places Status Indicator
• Refresh Wifi Connections
• Removable Drive Menu
• Remove Dropdown Arrows
• Screenshot window sizer
• Settingscenter
• Show ip
• System Monitor
• Taskbar
• Terminal as Root Button
• Toggle Touchpad
• Topicons
• Transparent Top Bar
• User Theme
• Window List
• Workspace Indicator
• Window Navigator

[justinnichols]

GNOME Shell 3.16.4
MMOD-Panel v1.1.1-7

I have all extensions turned off except MMOD Panel and the favorite/bookmark icons look just as grainy/non-anti-aliased as @steelbrain shows.

EDIT>> It's when the comfort level is set to anything except "Comfortable". The reason I believe is that the https://github.com/mmod/mmod-panel/blob/master/lib/mmod/favorites.js around line 323 is setting the width and height of the icons instead of using the icons' built-in scalability (i.e. it's setting a fixed size causing it to simply size down the large image, thus creating pixelation). I have no suggested fix, but as time permits I'll be glad to look into it.

[justinnichols]

I created this pull request that should fix this issue: #26

[seminull]

+1, thanks @justinnichols

[rawsh]

@justinnichols Your fix is not working for me

EDIT:

Nevermind, cloning your repo gave the wrong code. Copy pasting the pull request fixes it.

[justinnichols]

The branch should have had the right code since that's where the pull request comes from.

[kirvedx]

Hi there!

Thank you for your feedback. Would you please resubmit this issue at MMOD Panel @ Gitlab? If you do so I'll gladly merge the merge-request, I can cherry pick it if you refuse, but I'd like to have the history show your contribution properly and it's hosted and restructured over at Gitlab.

Debian won't use github because its not open source - so even though its free I do most of my daily work at gitlab.com. As a result, all of my projects have been migrated there from the old personally hosted repositories I used to maintain (which albeit were sorely unstable and unreliable).

I never really used github for this repository, it was always just a code mirror for when my network went down.

I can make the issue myself, but for history's sake - and for proper organization and conversation between submitter and assignee - it'd be awesome if you could go submit it at the appropriate repository.

Thanks!

[kirvedx]

Re-opened so you can comment back - if you dont have a gitlab account and dont want to open one, I'l just integrate the fix - its a simple one so I really don't mind either way.

Good work though, thanks for the contribution - I'll give some time to await your reply , and if you don't get back I'll note your contribution and implement it myself.

[kirvedx]

I'll probably cherry pick the commit from a fetch, a hopefully can maintain the authorship - and i'll try to get the code mirror integration set up on gitlab so github stays updated with all the latest commits from gitlab - that way I can easily take pull requests from github (sort of).

[justinnichols]

I have a gitlab account (same username), but did not carry over my fork for this repo since I no longer use mmod-panel. Please make the fix as you see fit :) Thanks for maintaining!