Skip to content

Support for PCRE2 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elfring opened this issue Nov 9, 2016 · 23 comments
Closed

Support for PCRE2 #10

elfring opened this issue Nov 9, 2016 · 23 comments

Comments

@elfring
Copy link

elfring commented Nov 9, 2016

How are the chances to support the current version (≧ “10.22”) of this programming interface for Perl-compatible regular expressions?

@mmottl
Copy link
Owner

mmottl commented Nov 10, 2016

The current PCRE-bindings satisfy my needs. If you need further functionality, feel free to submit pull requests, but please make sure that the API stays backward compatible and that the library can be compiled with older PCRE versions.

@mmottl mmottl closed this as completed Nov 10, 2016
@elfring
Copy link
Author

elfring commented Nov 10, 2016

Do you get any special software development concerns from introducing the usage of the prefix “pcre2” into the current source files?

@mmottl
Copy link
Owner

mmottl commented Nov 10, 2016

Yes, not everybody may have pcre2, there may be portability issues, etc. It's probably going to take a significant effort to support the new API. Not sure it's worth the effort.

@elfring
Copy link
Author

elfring commented Nov 11, 2016

  • Does this kind of feedback mean that you would prefer to maintain several versions of your software library in parallel on topic branches?
  • Which branch organisation will be selected?

@mmottl
Copy link
Owner

mmottl commented Nov 13, 2016

No, by this I meant that people use pcre on a large variety of platforms, some of which may not even have pcre2. If you want to make sure that they can still use the older pcre installation, you would have to add potentially non-trivial autoconfiguration code. You might also consider writing completely separate OCaml bindings for Pcre2 and leverage already existing OCaml code from the current bindings for that purpose. It might make some problems (e.g. backward compatibility) easier to solve.

@elfring
Copy link
Author

elfring commented Nov 13, 2016

  • How many software maintenance will be needed in parallel for the discussed versions?
  • Would you like to choose any further topic and development branches?

@mmottl
Copy link
Owner

mmottl commented Nov 14, 2016

It would probably be best to just start a fresh tree and copy as much as possible from the previous version. The amount of maintenance required will typically depend on the quality of the bindings (bugs) and how likely there will be portability issues.

@elfring
Copy link
Author

elfring commented Nov 14, 2016

I suggest to switch to the PCRE2 programming interface at a specific version of your OCaml library.
Which version number will be appropriate then?

@mmottl
Copy link
Owner

mmottl commented Nov 14, 2016

The latest release or even head of the master branch. This should make it easiest to adopt future changes.

@elfring
Copy link
Author

elfring commented Nov 14, 2016

Will other branch names be a bit safer for corresponding patch merges?

@mmottl
Copy link
Owner

mmottl commented Nov 14, 2016

There are currently no other branches. Feature branches are typically merged and eventually deleted.

@elfring
Copy link
Author

elfring commented Nov 14, 2016

I suggest to introduce a clearer separation between development branches.

@elfring
Copy link
Author

elfring commented Feb 27, 2017

How do you think about to use any software improvements which are mentioned in the PCRE change log?

@mmottl
Copy link
Owner

mmottl commented Feb 27, 2017

If I had a personal need for a feature, I would implement it, but the current PCRE API satisfies my needs. Feel free to contribute any patches that support unimplemented features.

@elfring
Copy link
Author

elfring commented Nov 18, 2018

Do your needs (or requirements by other contributors) evolve in a way which can include the use of a software like “PCRE 10.32”?

@mmottl
Copy link
Owner

mmottl commented Nov 19, 2018

My needs in that respect haven't changed.

@elfring
Copy link
Author

elfring commented Nov 19, 2018

Thanks for another feedback.

  • I am curious under which circumstances more users would prefer to stop working with outdated software.
  • I would generally prefer to work with more recent software components for some use cases. Would you ever like to help another bit here?

@mmottl
Copy link
Owner

mmottl commented Nov 19, 2018

As long as older software solves your problem, there is not much of an incentive to switch. If it isn't broken, don't fix it. If you have other needs, do it yourself or find other people with similar needs to help you.

@elfring
Copy link
Author

elfring commented Nov 19, 2018

The PCRE software was improved several times in the meantime.

  • It seems that OCaml programmers get more unwanted technical difficulties then.
  • Is it really hard to find companions with similar software development interests?

@mmottl
Copy link
Owner

mmottl commented Nov 19, 2018

I'm not aware of any technical issues with the current PCRE library. It has all the features I need and works flawlessly and efficiently.

Yes, as a matter of fact it is difficult to find people with similar software development interests. I have certainly never succeeded in getting my problems fixed by just waiting for other people to do that.

@elfring
Copy link
Author

elfring commented Nov 19, 2018

  • I hoped that you know more nice OCaml programmers (than me).
  • You might have lost interest in more significant extensions for this software library. I am curious if more incentives can be offered besides mentioned update possibilities which would be meaningful and useful also for you.

@mmottl
Copy link
Owner

mmottl commented Nov 19, 2018

If I needed an extension, I'd write it myself. There is no other incentive.

@elfring
Copy link
Author

elfring commented Nov 19, 2018

I am just looking again for possibilities and system preparations for corresponding software adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants