Expose test scripts for minimal/extended tests for mmtk-core #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wks
reviewed
Jan 19, 2024
.github/scripts/ci-test-minimal.sh
Outdated
Comment on lines
20
to
21
| export MMTK_PLAN=SemiSpace | ||
| runbms_dacapo2006_with_heap_multiplier fop 4 |
There was a problem hiding this comment.
If the plan is really intended to be set for one command, only, we can use the following syntax. In this way, we will not need to unset the env var again.
Suggested change
| export MMTK_PLAN=SemiSpace | |
| runbms_dacapo2006_with_heap_multiplier fop 4 | |
| MMTK_PLAN=SemiSpace runbms_dacapo2006_with_heap_multiplier fop 4 |
wks
approved these changes
Jan 19, 2024
.github/scripts/ci-test-minimal.sh
Outdated
Comment on lines
34
to
36
| export MMTK_VO_BIT=1 | ||
| $cur/ci-build.sh | ||
| unset MMTK_VO_BIT=1 |
There was a problem hiding this comment.
We can use the same trick here, too.
Suggested change
| export MMTK_VO_BIT=1 | |
| $cur/ci-build.sh | |
| unset MMTK_VO_BIT=1 | |
| MMTK_VO_BIT=1 $cur/ci-build.sh |
qinsoon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused workflow_dispatch for mmtk-core (see mmtk/mmtk-core#983), and adds a script to run minimal openjdk tests.