Disable console.errors in production mode when typechecking

[nathanbirrell]

Scenario

• Use typecheck to validate a model at runtime (with NODE_ENV=production)
• Cause an exception in that check using invalid data

Expected

Error is thrown by MST, so that I can catch it a level above, but no console.error gets logged in production.

Actual

Error is thrown by MST, console.error gets logged.

Do we really want to log console errors in production?

[mweststrate]

I think that is a bug, can you create a test case showing where a type error gets logged even when catched? Op di 24 apr. 2018 08:49 schreef Nathan Birrell <notifications@github.com>:

…

*Scenario* - Use typecheck to validate a model at runtime (with NODE_ENV=production) - Cause an exception in that check with invalid data *Expected* Error is thrown by MST, so that I can catch it a level above, but *no console.error gets logged* in production. *Actual* Error is thrown by MST, console.error gets logged. Do we really want to log console errors in production? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#781>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvGhFKyMpzE1E0au8D1WtUuygNXgqq_ks5trrz8gaJpZM4ThCf3> .

[nathanbirrell]

Sure @mweststrate - take a look at #785

[mweststrate]

This has been released a while ago