Properly destroy non-initialized nodes (fixes #1080)#1082
Merged
xaviergonz merged 3 commits intomasterfrom Nov 20, 2018
Merged
Conversation
Member
Author
|
BTW, shouldn't we keep master in par with latest release? |
Member
Author
|
@xaviergonz could you please take care of changelog? :) |
mweststrate
approved these changes
Nov 20, 2018
Member
mweststrate
left a comment
mweststrate
left a comment
There was a problem hiding this comment.
Looking good. No further comments :)
Contributor
|
Latest release is actually 3.8.0 😁 I'll update the change log and release a 3.8.1 |
Member
Author
|
Ops, seems like I had pulled changes just a few hours before you made 3.8! ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1080
Based on 7d55724 (v3.7.1).
This fix also makes nodes' destruction a little bit faster as we used to
walkover subtree, which internaly takesstoredValueand then jumps back to it'sObjectNode.Now we just use internal
getChildren()on node which also respects non-initialized nodes (i.e. withoudstoredValue).