Fix: Type instantiation is excessively deep and possibly infinite. TS2589 (TS3.4)#1251
Merged
xaviergonz merged 9 commits intomasterfrom Apr 9, 2019
Merged
Fix: Type instantiation is excessively deep and possibly infinite. TS2589 (TS3.4)#1251xaviergonz merged 9 commits intomasterfrom
xaviergonz merged 9 commits intomasterfrom
Conversation
xaviergonz
changed the title
Member
|
Great stuff @xaviergonz ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1247
Due to a new check for type nesting in TS3.4 (capped at 50 iterations) that only applies to .d.ts files (AFAIK), generated type definitions were giving this error with relatively small models.
This PR reduces the type nesting (from around 51 from the provided test case to around 12) by refactoring a bit the type system.
The only con is that the smarter "create" function, which was able to magically infer if create can or cannot take a snapshot has to be gone for this change to work. (Though anyway that feature seems to give some users some problems, see #1208 )
The good thing is that since the type nesting is greatly reduced IDE auto-completion should be even faster now.
I also checked type definition generation, now they are slightly smaller.