Skip to content

Fix applySnapshot to map<string,boolean> bug #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattiamanzati merged 3 commits into from
May 29, 2017
Merged

Fix applySnapshot to map<string,boolean> bug #155

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a12f0d6
Fix applySnapshot to map<string,boolean> bug
pioh May 29, 2017
e5dd80c
Map applySnapshot test
pioh May 29, 2017
4bc510a
Fix 'it should be the same each time' test
pioh May 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/types/complex-types/map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ export class MapType<S, T> extends ComplexType<{[key: string]: S}, IExtendedObse
fail(`A map of objects containing an identifier should always store the object under their own identifier. Trying to store key '${key}', but expected: '${item[identifierAttr]}'`)
// if snapshot[key] is non-primitive, and this.get(key) has a Node, update it, instead of replace
if (key in currentKeys && !isPrimitive(item)) {
currentKeys[key] = true
maybeMST(
target.get(key),
propertyNode => {
Expand All @@ -172,6 +171,7 @@ export class MapType<S, T> extends ComplexType<{[key: string]: S}, IExtendedObse
} else {
target.set(key, item)
}
currentKeys[key] = true
})
Object.keys(currentKeys).forEach(key => {
if (currentKeys[key] === false)
Expand Down