Repository navigation
Conversation
walk only visited the root node because ObjectNode.storedValue is undefined until the instance is lazily created, so the isStateTreeNode check never passed for untouched children. Reading .value on object nodes materializes them; scalar nodes still use .storedValue since their .value can differ (references resolve to the target node).
Collaborator
|
Thanks @cpruijsen - I'll take a look soon! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
walknow visits untouched model, array, and map children before their parent.Previously, an undefined
storedValuecaused traversal to skip those subtrees and sometimes visit only the root.In
src/core/mst-operations.ts,walkreads.valueforObjectNodechildren to initialize their instances.Scalar children retain the
storedValuepath, so traversal does not resolve reference targets or call custom reference resolvers.Instance initialization can run
afterCreateandafterAttachhooks.Fixes #1433.
Steps to validate locally
The three tests in
__tests__/core/1433.test.tscheck exact visit paths and order for untouched nested models, arrays, maps, and references.All three fail without the fix and pass with it in development and production modes.