Repository navigation
Conversation
lavrton
marked this pull request as ready for review
October 21, 2026 18:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Two changes to
applySnapshoton arrays of identified children.A moved child keeps its node. Since Optimize applySnapshot for mostly unchanged snapshots #2285 an unchanged-length snapshot assigns each changed index in place, which reconciles against the one node at that index. When a child moved, every index between its old and new position gets a new node. Now, when a changed entry carries the identifier of another current child, the array uses
replace, whose reconciliation finds the node by identifier and moves it. In Polotno, undoing one page reorder in a 100-page document recreated 71 pages; now none.A snapshot is validated once.
areSamevalidated a candidate (type.is) before comparing identifiers, so during reconciliation's look-ahead an inserted snapshot was validated once per following child. The identifier check now comes first for plain types; asnapshotProcessorkeeps the old order, since its preProcessor may throw on a snapshot of another union member (union.test.ts).Steps to validate locally
bun test __tests__/core/array-apply-snapshot-moves.test.ts— all three tests fail on master.NODE_ENV=development bun testandMST_TESTING=1 NODE_ENV=production bun testare green.