Add support for custom primitive-ish types#689
Merged
mweststrate merged 4 commits intomasterfrom Mar 14, 2018
Merged
Conversation
robinfehr
reviewed
Mar 11, 2018
Contributor
robinfehr
left a comment
robinfehr
left a comment
There was a problem hiding this comment.
looking awesome :) left a note about the isValidSnapshot.
|
|
||
| isValidSnapshot(value: any, context: IContext): IValidationResult { | ||
| if (this.options.isTargetType(value)) return typeCheckSuccess() | ||
| const typeError: string = this.options.isValidSnapshot(value) |
Contributor
There was a problem hiding this comment.
i think transpiled to js one could return true / false => the typeError within the error message would be Invalid value for type '${this.name}': true
also isValidSnapshot does imply that one should return a boolean.
maybe we could make that a bit more expressive to avoid confusion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #673