Skip to content

decorate incompatible with Babel 7's class properties #1471

@rgrochowicz

Description

@rgrochowicz

After trying out the latest create-react-app and mobx 4's decorate, I found that my classes were no longer observable. At first glance, it looks like it's Babel 7's class property transform.

Here's a codesandbox: https://codesandbox.io/s/623qwprm8k
I'd expect the updated value of FooBabel7 to trigger the autorun.

Differences in babel output:
Source:

class Foo {
  value = 1;
}

Babel 6:

class Foo {
  constructor() {
    this.value = 1;
  }
}

Babel 7:

class Foo {
  constructor() {
    Object.defineProperty(this, "value", {
      configurable: true,
      enumerable: true,
      writable: true,
      value: 1
    });
  }
}

Versions:
mobx: 4.1.1
babel: 7.0.0-beta.42
react-scripts: 2.0.0-next.b2fd8db8
Chrome: 65.0.3325.181

  • Provide a minimal sample reproduction.
  • Did you check this issue wasn't filed before?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions