Skip to content

dockerfile: update cni to 1.7.1 #5533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

dockerfile: update cni to 1.7.1 #5533

merged 1 commit into from
May 14, 2025

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Nov 19, 2024 •
edited
Loading

@crazy-max
Copy link
Member Author

Seems we got a bunch of test failure in buildkit and frontend: https://github.com/moby/buildkit/actions/runs/11916250858/job/33210058740?pr=5533#step:8:1844

=== FAIL: frontend TestFrontendIntegration/TestRefReadDir/worker=containerd-1.6 (1.43s)
    frontend_test.go:240: 
        	Error Trace:	/src/frontend/frontend_test.go:240
        	            				/src/util/testutil/integration/run.go:97
        	            				/src/util/testutil/integration/run.go:211
        	Error:      	Received unexpected error:
        	            	Unavailable: connection error: desc = "error reading server preface: read unix @->/tmp/bktest_buildkitd3532617275/buildkitd.sock: read: connection reset by peer"
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:82
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:204
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/api/services/control.(*controlClient).ListWorkers
        	            		/src/api/services/control/control_grpc.pb.go:130
        	            	github.com/moby/buildkit/client.(*Client).ListWorkers
        	            		/src/client/workers.go:31
        	            	github.com/moby/buildkit/client.(*Client).Build
        	            		/src/client/build.go:32
        	            	github.com/moby/buildkit/frontend.testRefReadDir
        	            		/src/frontend/frontend_test.go:235
        	            	github.com/moby/buildkit/util/testutil/integration.testFunc.Run
        	            		/src/util/testutil/integration/run.go:97
        	            	github.com/moby/buildkit/util/testutil/integration.Run.func2.1
        	            		/src/util/testutil/integration/run.go:211
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1690
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700
        	            	failed to list workers
        	            	github.com/moby/buildkit/client.(*Client).ListWorkers
        	            		/src/client/workers.go:33
        	            	github.com/moby/buildkit/client.(*Client).Build
        	            		/src/client/build.go:32
        	            	github.com/moby/buildkit/frontend.testRefReadDir
        	            		/src/frontend/frontend_test.go:235
        	            	github.com/moby/buildkit/util/testutil/integration.testFunc.Run
        	            		/src/util/testutil/integration/run.go:97
        	            	github.com/moby/buildkit/util/testutil/integration.Run.func2.1
        	            		/src/util/testutil/integration/run.go:211
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1690
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700
        	            	listing workers for Build
        	            	github.com/moby/buildkit/client.(*Client).Build
        	            		/src/client/build.go:34
        	            	github.com/moby/buildkit/frontend.testRefReadDir
        	            		/src/frontend/frontend_test.go:235
        	            	github.com/moby/buildkit/util/testutil/integration.testFunc.Run
        	            		/src/util/testutil/integration/run.go:97
        	            	github.com/moby/buildkit/util/testutil/integration.Run.func2.1
        	            		/src/util/testutil/integration/run.go:211
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1690
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700

@tonistiigi
Copy link
Member

also #5462 (comment)

@thompson-shaun thompson-shaun added this to the v0.19.0 milestone Nov 21, 2024
@thompson-shaun thompson-shaun mentioned this pull request Nov 21, 2024
Closed
@crazy-max crazy-max changed the title dockerfile: update cni to 1.6.0 dockerfile: update cni to 1.6.1 Dec 9, 2024
@crazy-max crazy-max changed the title dockerfile: update cni to 1.6.1 dockerfile: update cni to 1.6.2 Jan 10, 2025
@tonistiigi
Copy link
Member

Same EINTR stability errors in CI afaics.

@crazy-max
Copy link
Member Author

crazy-max commented Jan 14, 2025 •
edited
Loading

Same EINTR stability errors in CI afaics.

Yes it seems 1.6.2 is identical to 1.6.1 😣 : https://github.com/containernetworking/plugins/releases/tag/v1.6.2

https://github.com/moby/buildkit/actions/runs/12708513909/job/35425775767?pr=5533#step:8:2815

=== FAIL: frontend/dockerfile TestIntegration/TestIgnoreEntrypoint/worker=oci/frontend=client (0.16s)
    dockerfile_test.go:1539: 
        	Error Trace:	/src/frontend/dockerfile/dockerfile_test.go:1539
        	            				/src/util/testutil/integration/run.go:98
        	            				/src/util/testutil/integration/run.go:212
        	Error:      	Received unexpected error:
        	            	Unavailable: connection error: desc = "error reading server preface: read unix @->/tmp/bktest_buildkitd4007031790/buildkitd.sock: read: connection reset by peer"
        	            	github.com/moby/buildkit/util/stack.Enable
        	            		/src/util/stack/stack.go:82
        	            	github.com/moby/buildkit/util/grpcerrors.FromGRPC
        	            		/src/util/grpcerrors/grpcerrors.go:204
        	            	github.com/moby/buildkit/util/grpcerrors.UnaryClientInterceptor
        	            		/src/util/grpcerrors/intercept.go:41
        	            	google.golang.org/grpc.(*ClientConn).Invoke
        	            		/src/vendor/google.golang.org/grpc/call.go:35
        	            	github.com/moby/buildkit/api/services/control.(*controlClient).ListWorkers
        	            		/src/api/services/control/control_grpc.pb.go:130
        	            	github.com/moby/buildkit/client.(*Client).ListWorkers
        	            		/src/client/workers.go:31
        	            	github.com/moby/buildkit/client.(*Client).Build
        	            		/src/client/build.go:32
        	            	github.com/moby/buildkit/frontend/dockerfile.(*clientFrontend).Solve
        	            		/src/frontend/dockerfile/dockerfile_test.go:9595
        	            	github.com/moby/buildkit/frontend/dockerfile.testIgnoreEntrypoint
        	            		/src/frontend/dockerfile/dockerfile_test.go:1533
        	            	github.com/moby/buildkit/util/testutil/integration.testFunc.Run
        	            		/src/util/testutil/integration/run.go:98
        	            	github.com/moby/buildkit/util/testutil/integration.Run.func2.1
        	            		/src/util/testutil/integration/run.go:212
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1690
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700
        	            	failed to list workers
        	            	github.com/moby/buildkit/client.(*Client).ListWorkers
        	            		/src/client/workers.go:33
        	            	github.com/moby/buildkit/client.(*Client).Build
        	            		/src/client/build.go:32
        	            	github.com/moby/buildkit/frontend/dockerfile.(*clientFrontend).Solve
        	            		/src/frontend/dockerfile/dockerfile_test.go:9595
        	            	github.com/moby/buildkit/frontend/dockerfile.testIgnoreEntrypoint
        	            		/src/frontend/dockerfile/dockerfile_test.go:1533
        	            	github.com/moby/buildkit/util/testutil/integration.testFunc.Run
        	            		/src/util/testutil/integration/run.go:98
        	            	github.com/moby/buildkit/util/testutil/integration.Run.func2.1
        	            		/src/util/testutil/integration/run.go:212
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1690
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700
        	            	listing workers for Build
        	            	github.com/moby/buildkit/client.(*Client).Build
        	            		/src/client/build.go:34
        	            	github.com/moby/buildkit/frontend/dockerfile.(*clientFrontend).Solve
        	            		/src/frontend/dockerfile/dockerfile_test.go:9595
        	            	github.com/moby/buildkit/frontend/dockerfile.testIgnoreEntrypoint
        	            		/src/frontend/dockerfile/dockerfile_test.go:1533
        	            	github.com/moby/buildkit/util/testutil/integration.testFunc.Run
        	            		/src/util/testutil/integration/run.go:98
        	            	github.com/moby/buildkit/util/testutil/integration.Run.func2.1
        	            		/src/util/testutil/integration/run.go:212
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1690
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1700
        	Test:       	TestIntegration/TestIgnoreEntrypoint/worker=oci/frontend=client
    sandbox.go:187: stdout: /usr/bin/buildkitd --oci-worker=true --containerd-worker=false --oci-worker-gc=false --oci-worker-labels=org.mobyproject.buildkit.worker.sandbox=true --config=/tmp/bktest_config3492640188/buildkitd.toml --root /tmp/bktest_buildkitd4007031790 --addr unix:///tmp/bktest_buildkitd4007031790/buildkitd.sock --debugaddr unix:///tmp/bktest_buildkitd4007031790/buildkitd-debug.sock --debug
    sandbox.go:187: stderr: /usr/bin/buildkitd --oci-worker=true --containerd-worker=false --oci-worker-gc=false --oci-worker-labels=org.mobyproject.buildkit.worker.sandbox=true --config=/tmp/bktest_config3492640188/buildkitd.toml --root /tmp/bktest_buildkitd4007031790 --addr unix:///tmp/bktest_buildkitd4007031790/buildkitd.sock --debugaddr unix:///tmp/bktest_buildkitd4007031790/buildkitd-debug.sock --debug
    sandbox.go:190: > StartCmd 2025-01-10 11:29:35.955458816 +0000 UTC m=+62.271440568 /usr/bin/buildkitd --oci-worker=true --containerd-worker=false --oci-worker-gc=false --oci-worker-labels=org.mobyproject.buildkit.worker.sandbox=true --config=/tmp/bktest_config3492640188/buildkitd.toml --root /tmp/bktest_buildkitd4007031790 --addr unix:///tmp/bktest_buildkitd4007031790/buildkitd.sock --debugaddr unix:///tmp/bktest_buildkitd4007031790/buildkitd-debug.sock --debug
    sandbox.go:190: time="2025-01-10T11:29:36Z" level=debug msg="debug handlers listening at unix:///tmp/bktest_buildkitd4007031790/buildkitd-debug.sock"
    sandbox.go:190: time="2025-01-10T11:29:36Z" level=info msg="auto snapshotter: using overlayfs"
    sandbox.go:190: time="2025-01-10T11:29:36Z" level=debug msg="could not read \"/tmp/bktest_buildkitd4007031790/net/cni\" for cleanup: open /tmp/bktest_buildkitd4007031790/net/cni: no such file or directory"
    sandbox.go:190: time="2025-01-10T11:29:36Z" level=debug msg="creating new network namespace 2z6cq9ac0wl56eyta23u2ndi9"
    sandbox.go:190: time="2025-01-10T11:29:36Z" level=debug msg="finished creating network namespace 2z6cq9ac0wl56eyta23u2ndi9"
    sandbox.go:190: buildkitd: plugin type="loopback" failed (add): interrupted system call
    sandbox.go:190: CNI setup error
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.(*cniProvider).newNS
    sandbox.go:190: 	/src/util/network/cniprovider/cni.go:292
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.(*cniPool).getNew.func1
    sandbox.go:190: 	/src/util/network/cniprovider/cni.go:183
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.withDetachedNetNSIfAny
    sandbox.go:190: 	/src/util/network/cniprovider/cni_linux.go:97
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.(*cniPool).getNew
    sandbox.go:190: 	/src/util/network/cniprovider/cni.go:186
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.(*cniPool).get
    sandbox.go:190: 	/src/util/network/cniprovider/cni.go:176
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.(*cniProvider).New
    sandbox.go:190: 	/src/util/network/cniprovider/cni.go:246
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.(*cniProvider).initNetwork
    sandbox.go:190: 	/src/util/network/cniprovider/cni.go:94
    sandbox.go:190: github.com/moby/buildkit/util/network/cniprovider.New
    sandbox.go:190: 	/src/util/network/cniprovider/cni.go:72
    sandbox.go:190: github.com/moby/buildkit/util/network/netproviders.Providers
    sandbox.go:190: 	/src/util/network/netproviders/network.go:53
    sandbox.go:190: github.com/moby/buildkit/worker/runc.NewWorkerOpt
    sandbox.go:190: 	/src/worker/runc/runc.go:49
    sandbox.go:190: main.ociWorkerInitializer
    sandbox.go:190: 	/src/cmd/buildkitd/main_oci_worker.go:318
    sandbox.go:190: main.newWorkerController
    sandbox.go:190: 	/src/cmd/buildkitd/main.go:859
    sandbox.go:190: main.newController
    sandbox.go:190: 	/src/cmd/buildkitd/main.go:779
    sandbox.go:190: main.main.func3
    sandbox.go:190: 	/src/cmd/buildkitd/main.go:343
    sandbox.go:190: github.com/urfave/cli.HandleAction
    sandbox.go:190: 	/src/vendor/github.com/urfave/cli/app.go:524
    sandbox.go:190: github.com/urfave/cli.(*App).Run
    sandbox.go:190: 	/src/vendor/github.com/urfave/cli/app.go:286
    sandbox.go:190: main.main
    sandbox.go:190: 	/src/cmd/buildkitd/main.go:407
    sandbox.go:190: runtime.main
    sandbox.go:190: 	/usr/local/go/src/runtime/proc.go:272
    sandbox.go:190: runtime.goexit
    sandbox.go:190: 	/usr/local/go/src/runtime/asm_amd64.s:1700
    sandbox.go:190: > stopped 2025-01-10 11:29:36.11233483 +0000 UTC m=+62.428316593 exit status 1 1

@crazy-max crazy-max modified the milestones: v0.19.0, v0.20.0 Jan 15, 2025
@AkihiroSuda AkihiroSuda mentioned this pull request Jan 20, 2025
Closed
@thompson-shaun thompson-shaun modified the milestones: v0.20.0, v0.future Feb 6, 2025
@crazy-max crazy-max changed the title dockerfile: update cni to 1.6.2 dockerfile: update cni to 1.7.1 May 14, 2025
@crazy-max
Copy link
Member Author

crazy-max commented May 14, 2025 •
edited
Loading

Same EINTR stability errors in CI afaics.

Seems it has been fixed in containernetworking/plugins#1154.

Rebased if we want this one in for first RC.

@crazy-max crazy-max modified the milestones: v0.future, v0.22.0 May 14, 2025
@crazy-max crazy-max self-assigned this May 14, 2025
@crazy-max crazy-max marked this pull request as ready for review May 14, 2025 15:35
@crazy-max crazy-max merged commit 141a4a6 into moby:master May 14, 2025
111 checks passed
@crazy-max crazy-max deleted the update-cni branch May 14, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

Assignees

@crazy-max crazy-max

Labels
area/project
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - CVE-2024-24791 / CVE-2022-30635 / CVE-2024-34155 / CVE-2024-34156 / CVE-2024-34158
3 participants
@crazy-max @tonistiigi @thompson-shaun