Repository navigation
was never called overload has limitations #54
Description
Writing something like
aMock.doSomethingWithThisIntAndString(*, "test") was never called
aMock.doSomethingWithThisIntAndString(*, "test") was never calleddoesn't compile
while
aMock.doSomethingWithThisIntAndString(*, "test") was never called
// line break is required to compile
aMock.doSomethingWithThisIntAndString(*, "test") was never called
compiles fine
Activity
jozic commentedon Nov 6, 2018
@bbonanno fyi
ultrasecreth commentedon Nov 7, 2018
@jozic Yeah, I've seen this before somewhere else, I'm not exactly sure if it can be solved while keeping the same syntax (I wouldn't like to introduce antother breaking change)
Ideas?
jozic commentedon Nov 7, 2018
I understand that breaking changes are bad, but non compiling code is even worse :)
and it wasn't like I figured out the solution in 5 seconds, I was almost at the point to give up
so i personally think it should be fixed at any cost, but of course this is just my opinion
ultrasecreth commentedon Nov 7, 2018
The problem is that the postfix notation can not always infer where the
;goes, that's one of the reasons why it's hidden behind a feature flagmy point is I'm not sure how to re-write the 3 use cases in case that's the only solution, i.e.
How can we semantically re-write those 3 while keeping an english syntax that makes sense
jozic commentedon Nov 8, 2018
was never calledAgain?was neverCalled again?it looks worse then all words separately, but we already sort of have similar case with
was calledandwasCalled onceultrasecreth commentedon Nov 8, 2018
@jozic not sure if you get the notifications for the PR #56, so just in case I drop this "please check it out here" :)