Upgrade mockito-core to 5.18.0, add support for JDK 17 and 21, drop Scala 2.11 and JDK 8#559
Conversation
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Only 1 small comment. The rest LGTM! Thanks for the fixes.
| # The version is inferred by shipkit-auto-version Gradle plugin | ||
| # More: https://github.com/shipkit/shipkit-auto-version | ||
| version=1.17.* No newline at end of file | ||
| version=1.18.* No newline at end of file |
There was a problem hiding this comment.
We should make this a 2.0.* release, since we are dropping support for various configurations.
There was a problem hiding this comment.
Sure, will update
Should we then also drop some long time deprecated methods?
There was a problem hiding this comment.
Or I guess, we can do that in 2.0.1 as well :)
…cala 2.11 and JDK 8
jozic
force-pushed
the
mockito-5.18-jdk-17-21
branch
from
c248e45 to
0b5b666
Compare
|
@TimvdLippe bumped version to 2.0.0 |
|
Right. Let's drop these deprecated methods as well indeed. All of them appear to have appropriate replacements, so it should be doable for users to migrate. Thanks again for all the effort in getting this project up-to-date again |
|
@TimvdLippe I will send a separate commit to this PR and I suggest we don't squash those commits to keep history clean and easy to navigate |
|
@TimvdLippe I've dropped all the deprecated methods with replacements, but kept also, not sure why but seems like Gradle wrapper check is unstable |
|
@jozic Seems like by bumping the Java version of the release job to 17, it now fails: https://github.com/mockito/mockito-scala/actions/runs/15277155793/job/42966910185 That's because we still use Gradle 6 (old!). Can you update our Gradle wrapper to the latest version as well and create a new PR? Thanks! |
|
@TimvdLippe you made the change in #560, right? Also, can you think of a way to automatically check depending projects like mockito-scala, mockito-kotlin, etc when mockito-core is changed? Ideally when PR is opened or at least when a new version is released |
|
@jozic No I didn't upgrade Gradle. I only upgraded the GitHub action that verifies Gradle according to the checksum. We expect them as normal consumers, e.g. they shouldn't break. Of course that sometimes is more tricky than we would like, but in general we strive to never break our users including our own dependent artifacts. |
2 participants
fixes #350
fixes #515
fixes #520
fixes #556
closes #517