Fix Scala 3 shouldReturn/mustReturn inference for polymorphic methods#652
Merged
TimvdLippe merged 1 commit intoApr 9, 2026
Merged
Conversation
Contributor
Author
|
@TimvdLippe please take a look, small fix, not critical, but good for parity |
TimvdLippe
approved these changes
Apr 9, 2026
TimvdLippe
left a comment
TimvdLippe
left a comment
Contributor
There was a problem hiding this comment.
Some real type system shenanigans going on here, but seems fair to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered this during testing on some projects
Scala 3 types the mocked call before it sees the value passed to
shouldReturn/mustReturn. For polymorphic methods that can widen the inferred return type too much, so this adds direct single-value overloads that let inference use both sides of the stub.I added a shared test that runs for all scala versions