[raphw]

Checks the command line arguments for the EnableDynamicAgentLoading argument and does not warn about dynamic attach, if the option is set.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.55%. Comparing base (2e7992b) to head (374c605).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...java/org/mockito/internal/PremainAttachAccess.java	65.00%	6 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3551      +/-   ##
============================================
- Coverage     85.60%   85.55%   -0.05%     
- Complexity     2954     2955       +1     
============================================
  Files           341      341              
  Lines          8976     8995      +19     
  Branches       1118     1119       +1     
============================================
+ Hits           7684     7696      +12     
- Misses         1003     1009       +6     
- Partials        289      290       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TimvdLippe]

Nice!

[schabe77]

This doesn't work for me. That's because

mockito/mockito-core/src/main/java/org/mockito/internal/PremainAttachAccess.java

Lines 50 to 55 in e04dbbe

	List<String> arguments =
	(List<String>)
	runtimeMXBean
	.getClass()
	.getMethod("getInputArguments")
	.invoke(runtimeMXBean);

results in a

java.lang.IllegalAccessException: class org.mockito.internal.PremainAttachAccess cannot access class sun.management.RuntimeImpl (in module java.management) because module java.management does not export sun.management to unnamed module @78b66d36

and therefore in dynamicAgentLoading = false;

But it works, when getInputArguments is requested without Reflection:

        RuntimeMXBean runtimeMXBean = (RuntimeMXBean)
                Class.forName("java.lang.management.ManagementFactory")
                        .getMethod("getRuntimeMXBean")
                        .invoke(null);
       dynamicAgentLoading =
                runtimeMXBean.getInputArguments().stream()
                        .anyMatch(
                                argument ->
                                        argument.contains(
                                                "-XX:+EnableDynamicAgentLoading"));

[raphw]

Indeed, this is an annoying implication of the module system if a method is resolved against an overriding class, not the interface. I will need to change that to get the interface class and to invoke the method on it.

[raphw]

Suggested fix: #3566