Skip to content

Bump rollout sglang to v0.5.22 and digest-pin - #132

Draft
Andrew Hinh (andrewhinh) wants to merge 1 commit into
mainfrom
devin/1792888978-sglang-0522
Draft

Andrew Hinh (andrewhinh) wants to merge 1 commit into
mainfrom
devin/1792888978-sglang-0522

Conversation

@andrewhinh

Copy link
Copy Markdown
Collaborator

SGLANG_IMAGE uses mutable tag lmsysorg/sglang:v0.5.21, which is vulnerable to the SGLang RCE fixed in v0.5.22.

This PR bumps it to v0.5.22@sha256:e3a4f060… (the digest dojo's sglang recipe already pins) and moves SGLANG_BRANCH to spindle-sglang-v0.5.22.

Blocked on the fork: spindle-sglang-v0.5.22 does not exist on modal-projects/sglang yet — someone needs to port the spindle-sglang-v0.5.21 delta (weight-sync stack + DeepSeek-V4 LoRA backports, ~30 commits) onto upstream v0.5.22 and push that branch before this merges, else image builds fail cloning it.

Link to Devin session: https://modal.devinenterprise.com/sessions/c3c6f128807747fe949152118603683c
Open in Devin Desktop: https://modal.devinenterprise.com/desktop/session/c3c6f128807747fe949152118603683c?variant=devin
Requested by: Andrew Hinh (@andrewhinh)

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant