Repository navigation
Revert the SPINDLE_EXCLUDE_RESERVED_CAPACITY environment variable - #306
Merged
Merged
Conversation
Micah Yong (micahtyong)
requested a review
from Kailash Ranganathan (kailash109)
as a code owner
November 16, 2026 20:25
Micah Yong (micahtyong)
deleted the
micah/revert-exclude-reserved-env
branch
November 16, 2026 20:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #292. The
SPINDLE_EXCLUDE_RESERVED_CAPACITYvariable changed a recipe's platform settings depending on the shell that loaded it. The same frontend deployed from two places could flip between settings, and each flip redeploys every app on it. Set"platform.modal.exclude_reserved_capacity": Truein the recipe instead, so the setting is visible and stays the same wherever it's deployed.E2E
tests/test_deployments.py,tests/test_deployment_cli.pyandtests/providers/test_deployment_apps.pypass, and pre-commit passes.🤖 Generated with Claude Code