Repository navigation
Keep the Miles images that restore 0.1.7 checkpoints - #370
Merged
Merged
Conversation
A Miles LoRA checkpoint restores only on the Miles revision that saved it. #361 removed the three images every 0.1.x release trained on, so training states saved by 0.1.7 and earlier could no longer be restored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Micah Yong (micahtyong)
requested a review
from Kailash Ranganathan (kailash109)
as a code owner
November 18, 2026 02:34
Micah Yong (micahtyong)
added a commit
that referenced
this pull request
Nov 18, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Miles LoRA checkpoint restores only on the Miles revision that saved it. #361 removed
miles-v0.1.1-fdd808c,miles-v0.1.2-f2f8447andmiles-v0.1.2-464efc9-glm53, the images Spindle 0.1.7 and earlier trained on, so training states saved before the seeded images could no longer be restored withload_state. This adds them back as restore-only names, allowed by the unused-image test, and documents when to use them. It also points the native-adapter note atmiles-v0.2.0-8c5de26instead of the removedmiles-v0.2.0-15afe21.Testing
pytest tests/providers/test_deployment_apps.py tests/test_deployments.pyand pre-commit pass. The restored names build the sameimage_atcommits as before #361. On main with that image defined in user code, a Qwen3.5-4B LoRA checkpoint saved onfdd808crestored withload_state_with_optimizerthrough the stock Tinker SDK, and a save and reload after one more step matched exactly (W&B).