Repository navigation
Backport Inkling-2-Small with attention/unembedding multi-LoRA - #45
Open
kailash109 wants to merge 2 commits into
Open
kailash109 wants to merge 2 commits into
kailash109 wants to merge 2 commits into
Conversation
Backport radixark#4819 at eac7f8c onto spindle-miles-v0.2.0. Keep the complete single-adapter layout and derive an attention/unembedding spec for explicitly restricted targets. Slot the output head and reject routed-expert multi-LoRA at startup.
kailash109
marked this pull request as ready for review
November 18, 2026 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport radixark#4819 (
eac7f8cc79c09e7b3dcbb6bef3029dc8323390f0) ontospindle-miles-v0.2.0, including the Inkling2 model, checkpoint conversion, native LoRA specs, quantization support, launchers, and tests.Add native multi-LoRA for explicitly selected attention and unembedding targets (
--target-modules attn,unembed). Construct output-head adapters through the slot builder and reject routed-expert multi-LoRA at startup. Derive the restricted architecture spec per target selection; default single-adapter LoRA retains the complete attention/expert/unembedding layout and shared-outer experts.Spindle PR 342 pins full-model-validated commit
e186d97710dcc319da659f8bc25dbb674e227909, which remains an ancestor after merging the updated v0.2 base. Training uses TP=CP=PP=1 and expert parallelism. This recipe uses separate trainer and sampler nodes.Validation
Merged PR head
d23367105d09833dad3c91f490c90aefa18b80c2, in the matched Inkling image on B300:e8142459617f8220825ddbacf054b8b17cabdd82: 669 passed, 23 failed, 4 errors. The failing/error case sets are identical; no new failures. The full launcher suite is not green.Full-checkpoint E2E applies to frozen Miles
e186d977with Spindle3e0139d, not the newer merged Miles head. It used separate eight-B300 trainer and sampler nodes withexclude_reserved_capacity=True:The Spindle PR includes required sampler precision and target-alias fixes, a reproducible stock-SDK check, and sanitized validation evidence. Expert adapters, B200, colocation, image inputs, restart, convergence, and full-model mixed-client batches were not validated. The frozen runtime also passed 208 native-LoRA tests and three focused CPU/CUDA adapter checks before the base merge.
Temporary validation apps were stopped; a container listing confirmed no remaining validation GPU containers. Shared model assets and checkpoints were retained.