Improve nodes (un)locking #261
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajik
force-pushed
the
fix-locking
branch
3 times, most recently
from
4ed1b63 to
aed3158
Compare
|
@jajik Unrelated - but can you look into replacing strings such as "text/plain" with macros as well? I see you are changing lines that include it and it's repeated many times.. Thx. |
jajik
force-pushed
the
fix-locking
branch
2 times, most recently
from
a0061f3 to
caf1303
Compare
|
This needs a revisit:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft, because there might be more.