Fix handling of duplicite MCMP command parameters #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfclere
approved these changes
Jun 24, 2025
TODO: It changed in 0e0d8ea, however, this needs a revisit, see modcluster#330
|
@rhusar Could you please eventually change the required checks so that we can merge it? |
|
already changed some but it looks like i missed these. Will fix. |
|
It's not very intuitive... Thank you! |
|
Required checks is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #329 and adds additional tests for it. However, there is an error message change for which I opened #330. (tl;dr This unifies the behaviour of 2.x with 1.3.x but both are inaccurate.)