-
Notifications
You must be signed in to change notification settings - Fork 16
Use only port 8000 in tests #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What makes this the pick? Port 6666 is primarily associated with IRC communications but is also notorious for malware use. I am not convinced.
We're currently using two (and we've been since I remember) and I usually accessed through |
Drop port 6666 completely as two ports are not needed
@rhusar I changed the port to the other one we are using (8000). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not going to like this, but the 8000 is used by tomcat as the default JDPA port. It can be changed to any port, but this is default, which makes little sense to have conflicting ports in a default setup.
These were chosen poorly, for debugging with no thought given to it, which has lead to numerous problems. Lets pick one that won't cause any problems and conflicts that we know of. |
Thinking out load, how about port 9000 (or variation of that like 9090)? It's typically used as alternative http port, perhaps that's reasonable for mod_cluster manager. That would make public proxy address 80, Tomcat and WildFly default HTTP port 8080, Tomcat debugging 8000. |
Scratch that, just use the port 8090 that we use in WildFly/Undertow implementation and stop reinventing the wheel. |
😄 @jfclere Any input on this? |
BTW Here's the Jira for this https://issues.redhat.com/browse/MODCLUSTER-858 |
Docs part for this: modcluster/docs.modcluster.io#244 |
@jajik Please use 8090 as suggested in https://issues.redhat.com/browse/MODCLUSTER-858 |
@jfclere Done |
For some (historic?) reasons we've been using two ports in tests, so let's use just one instead.