Skip to content

Conversation

jajik
Copy link
Member

@jajik jajik commented Aug 13, 2025

If you have a look at the dependabot behavior, it always creates a branch and opens a pull request. That means the CI runs twice (for each event, see this for example) within the project. We can add dependabot's branches among ignored for the push event so that the workflow runs only once.

We don't pay for the workflows, and we're usually not limited by the queue, so it's not needed, but it won't hurt.
(Also, I tried it in the "perf suite" repo and it seems it erases all the run logs triggerd by push on dependabot's branches from the past – an interesting effect).

@jajik jajik requested a review from rhusar August 13, 2025 13:02
Copy link
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, I knew this was a problem, but never looked into it deep enough. This makes sense.

@rhusar rhusar merged commit 6c3e497 into modcluster:main Aug 13, 2025
14 checks passed
@jajik jajik deleted the ci-dependabot-tweak branch August 13, 2025 13:11
@jajik
Copy link
Member Author

jajik commented Aug 13, 2025

Thanks for the review.

@rhusar
Copy link
Member

rhusar commented Aug 13, 2025

BTW The other option is to explicitly enumerate branches for which to run CI. But this approach seems more convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants